Attention is currently required from: Marc Jones, Patrick Rudolph, Jonathan Zhang, Rocky Phagura, Jingle Hsu, Angel Pons, Arthur Heymans, Morgan Jang, Kyösti Mälkki.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49460 )
Change subject: cpu/x86/smm: Enable setting SMM console log level from mainboard
......................................................................
Patch Set 21:
(3 comments)
Patchset:
PS20:
Johnny, could you rebase this patch set?
Done.
File src/cpu/x86/smm/smm_module_handler.c:
https://review.coreboot.org/c/coreboot/+/49460/comment/35a896cf_87140229
PS20, Line 17: #if CONFIG(DEBUG_SMI) && CONFIG(OVERRIDE_UART_FOR_CONSOLE)
: u32 smm_uart_for_console;
: #endif
smm_uart_for_console is not used by any mainboard so should be removed.
Done
https://review.coreboot.org/c/coreboot/+/49460/comment/47805f92_c04090f3
PS20, Line 166: console_init();
Should avoid doing console_init/deinit() when smm_log_level is 0 to avoid unnecessary overhead and a […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49460
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81722a4f1bf75ec942cc06e403ad702dfe938e71
Gerrit-Change-Number: 49460
Gerrit-PatchSet: 21
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Rocky Phagura
rphagura@fb.com
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 31 Oct 2022 04:24:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-MessageType: comment