Attention is currently required from: Nicholas Sudsgaard.
Nicholas Chin has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/80411?usp=email )
Change subject: Documentation/mainboard/lenovo: Add ThinkCentre M710s ......................................................................
Patch Set 22:
(1 comment)
File Documentation/mainboard/lenovo/thinkcentre_m710s_spi_location.jpg:
PS22: Could you shrink this image? As per https://doc.coreboot.org/getting_started/writing_documentation.html#basic-an...
Images should be kept small. They should be under 700px in width, as the current theme doesn’t allow bigger images.
That said, I did a build test and it seems to render properly, so it might not be an issue anymore. Regardless, 3744x2904 is way more than necessary just to show where the SPI flash is. Somethine else that was suggested in review of one of my previous docs patches:
https://jpeg-optimizer.com/ at 80% quality greatly reduces file size
It would be good to document the unwritten rule of "any images in the coreboot repo used in documentation should be as small as possible so as not to bloat the repo too much" and mention image optimizer websites (without linking to any site in particular).