Hello Varun Joshi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/40896
to review the following change.
Change subject: soc/intel: Add acpi support for enabling GbE ......................................................................
soc/intel: Add acpi support for enabling GbE
-Provides acpi irq info for enabling GbE
Signed-off-by: Varun Joshi varun.joshi@intel.corp-partner.google.com Change-Id: I1e6ad3e38f001e934742df4bdc5de2f6b8a0f8b6 --- M src/soc/intel/tigerlake/acpi/pci_irqs.asl M src/soc/intel/tigerlake/include/soc/irq.h 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/40896/1
diff --git a/src/soc/intel/tigerlake/acpi/pci_irqs.asl b/src/soc/intel/tigerlake/acpi/pci_irqs.asl index 62520b1..865f91a 100644 --- a/src/soc/intel/tigerlake/acpi/pci_irqs.asl +++ b/src/soc/intel/tigerlake/acpi/pci_irqs.asl @@ -17,6 +17,7 @@
Name (PICP, Package () { /* D31:HDA, SMBUS, TraceHUB */ + Package(){0x001FFFFF, 0, 0, GbE_INTA_IRQ }, Package(){0x001FFFFF, 3, 0, HDA_IRQ }, Package(){0x001FFFFF, 4, 0, SMBUS_IRQ }, Package(){0x001FFFFF, 7, 0, TRACEHUB_IRQ }, diff --git a/src/soc/intel/tigerlake/include/soc/irq.h b/src/soc/intel/tigerlake/include/soc/irq.h index 01ee10b..7768fec 100644 --- a/src/soc/intel/tigerlake/include/soc/irq.h +++ b/src/soc/intel/tigerlake/include/soc/irq.h @@ -27,6 +27,7 @@ #define HDA_IRQ 16 #define SMBUS_IRQ 16 #define TRACEHUB_IRQ 16 +#define GbE_INTA_IRQ 16
#define PCIE_1_IRQ 16 #define PCIE_2_IRQ 17
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40896 )
Change subject: soc/intel: Add acpi support for enabling GbE ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40896/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40896/1//COMMIT_MSG@7 PS1, Line 7: acpi ACPI
https://review.coreboot.org/c/coreboot/+/40896/1//COMMIT_MSG@7 PS1, Line 7: intel soc/intel/tigerlake
https://review.coreboot.org/c/coreboot/+/40896/1//COMMIT_MSG@9 PS1, Line 9: -Provides acpi irq "Provides ACPI IRQ"
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40896 )
Change subject: soc/intel: Add acpi support for enabling GbE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40896/1/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/pci_irqs.asl:
https://review.coreboot.org/c/coreboot/+/40896/1/src/soc/intel/tigerlake/acp... PS1, Line 20: Package(){0x001FFFFF, 0, 0, GbE_INTA_IRQ }, Where can I find this information?
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40896 )
Change subject: soc/intel: Add acpi support for enabling GbE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40896/1/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/pci_irqs.asl:
https://review.coreboot.org/c/coreboot/+/40896/1/src/soc/intel/tigerlake/acp... PS1, Line 94: Package () { 0x001FFFFF, 3, 0, 11 }, Package () { 0x001FFFFF, 0, 0, 11 }, need add here as well?
Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40896 )
Change subject: soc/intel: Add acpi support for enabling GbE ......................................................................
Patch Set 1:
Patch Set 1:
(1 comment)
Checking this internally.
Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40896 )
Change subject: soc/intel: Add acpi support for enabling GbE ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
(1 comment)
Checking this internally.
This change is taken care here: https://review.coreboot.org/c/coreboot/+/41153 Hence, I will be abandoning this patch.
Varun Joshi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40896 )
Change subject: soc/intel: Add acpi support for enabling GbE ......................................................................
Abandoned
This change is taken care here: https://review.coreboot.org/c/coreboot/+/41153 Hence, I will be abandoning this patch
-
EricR Lai (Code Review) -
Tim Wawrzynczak (Code Review)
-
Varun Joshi (Code Review)