Attention is currently required from: Tarun Tuli, Subrata Banik.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68220 )
Change subject: mb/google/rex: Add initial fw config ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68220/comment/8b8ed8f0_6211b514 PS3, Line 13: affter
after
Ack
File src/mainboard/google/rex/variants/rex0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68220/comment/0aaadc12_d7d370fb PS3, Line 25: USB3
USB3_PS8815
Ack
https://review.coreboot.org/c/coreboot/+/68220/comment/0c27d971_156d5a30 PS3, Line 156: probe DB_USB USB3 : probe DB_USB USB4
i don't think it's needed
It will remove unnecessary ACPI code when USB DB is not present on a SKU. Is there any down side of it?
-
Kapil Porwal (Code Review)