Attention is currently required from: Eric Lai, Jakub Czapiga, John Su, John Zhao, Kapil Porwal, Matt DeVillier, Sean Rhodes, Subrata Banik.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72909?usp=email )
Change subject: soc/intel/common/tcss: Configure USB-C ports with attached devices
......................................................................
Patch Set 5: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72909/comment/a342f131_ce15655e :
PS5, Line 9: TCC
What does TCC mean?
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/72909/comment/30f986bb_687c5e48 :
PS5, Line 363: zd
`%zu` ?
https://review.coreboot.org/c/coreboot/+/72909/comment/40610afb_092c243f :
PS5, Line 364: continue;
Not sure, but linter may complain that this `continue;` is currently useless.
https://review.coreboot.org/c/coreboot/+/72909/comment/aa1269b0_b1c0ed2a :
PS5, Line 459: if (CONFIG(EC_GOOGLE_CHROMEEC))
This condition seems wrong. Is it because ChromeEC uses FCM (Firmware Connection Manager) whereas others use SCM (Software Connection Manager)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72909?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69522dbcc8cae6bbf41659ae653107d0e031c812
Gerrit-Change-Number: 72909
Gerrit-PatchSet: 5
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: CoolStar
coolstarorganization@gmail.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Jakub Czapiga
jacz@semihalf.com
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 03 Aug 2023 15:09:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment