Attention is currently required from: Paul Menzel.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85693?usp=email )
Change subject: mb/starlabs/*: Declare all DDI interfaces ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85693/comment/7b4179d7_da142f30?usp... : PS2, Line 8:
`'noticable' may be misspelled - perhaps 'noticeable'?` […]
Done
https://review.coreboot.org/c/coreboot/+/85693/comment/f142ce68_f7b5142b?usp... : PS2, Line 12:
How can this be tested? Some log line?
I can't see any difference whatsoever, in both Linux and Windows!
File src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/85693/comment/f417639b_0783af8d?usp... : PS2, Line 22: [DDI_PORT_A] = DDI_ENABLE_HPD,
Excuse my ignorance, how does this relate with the commit message? You remove `DDI_ENABLE_DDC`.
Port A is eDP
-
Sean Rhodes (Code Review)