[M] Change in coreboot[master]: mb/google/skyrim: Use CMOS bit to toggle ABL WA for Hynix DRAM

[Martin Roth (Code Review)]

Attention is currently required from: Eric Lai, Felix Held, Jason Glenesk, Jason Nien, Karthik Ramasubramanian, Matt DeVillier, Paul Menzel.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75698?usp=email )

Change subject: mb/google/skyrim: Use CMOS bit to toggle ABL WA for Hynix DRAM
......................................................................

Patch Set 4: Code-Review+2

(4 comments)

File src/mainboard/google/skyrim/bootblock.c:

https://review.coreboot.org/c/coreboot/+/75698/comment/5383021a_872d599d :
PS2, Line 17: 18
> I'm using the full length allowed the SPD spec for the cbi_part_number array, which is 33 bytes, so  […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/75698/comment/da4a0696_9884a65e :
PS2, Line 94: hynix_dram_cmos_check();
> I'm perfectly happy to just restict this to just FF, adding another Kconfig seems unnecessary

Agreed - I was just looking for a way to not run it on platforms that didn't need it.  It should be on the OEMs to take care of adding the fix for their platforms if needed.

File src/mainboard/google/skyrim/bootblock.c:

https://review.coreboot.org/c/coreboot/+/75698/comment/e5f97685_8390853b :
PS3, Line 32: google_chromeec_cbi_get_dram_part_num
> since it's passed directly to the EC via a host cmd, it appears it would overflow if too short. […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/75698/comment/a0c94987_49389b81 :
PS3, Line 35: return;
> I think there are reasonable arguments for leaving it and for clearing it. […]

Acknowledged