Attention is currently required from: Rex-BC Chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53894 )
Change subject: soc/mediatek/mt8195: Add i2c driver support
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/mt8195/i2c.c:
https://review.coreboot.org/c/coreboot/+/53894/comment/f1b610be_3d31c332
PS3, Line 109: gpio_set_mode(ptr[i].gpio, ptr[i].func);
I can not reproduce this issue from my local environment. […]
I think this is related to the compiler version, as this warning happens after updating GCC from 11.2 to 12.2 (CB:67821). Yes, looking at the code, no practical problem will occur, but we have to figure out if this is GCC's bug. If this is the intended behavior of GCC 12.2, we'll need to fix the code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53894
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia26e55512501e9758d7f5543d176730cf30ce03d
Gerrit-Change-Number: 53894
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Comment-Date: Mon, 05 Dec 2022 08:32:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rex-BC Chen
rex-bc.chen@mediatek.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment