Attention is currently required from: Arthur Heymans, Marc Jones, Nico Huber, Angel Pons, lichenchen.carl, Shuming Chu (Shuming), Nill Ge.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64035 )
Change subject: arch/x86/smbios.c: Allow creating entries for empty DIMM slots
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/64035/comment/521857fd_6de66194
PS1, Line 295: t->manufacturer = smbios_add_string(t->eos, "NO DIMM");
: t->serial_number = smbios_add_string(t->eos, "NO DIMM");
: t->asset_tag = smbios_add_string(t->eos, "NO DIMM");
: t->part_number = smbios_add_string(t->eos, "NO DIMM");
We may want to fill in those fields with empty strings.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17ae83edf94483bd2eeef5524ff82721c196b8ba
Gerrit-Change-Number: 64035
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: lichenchen.carl
lichenchen.carl@bytedance.com
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: lichenchen.carl
lichenchen.carl@bytedance.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 07 Nov 2022 21:57:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment