Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57024 )
Change subject: WIP: Herobrine: Fix board id read to use base3 ......................................................................
WIP: Herobrine: Fix board id read to use base3
Board IDs are tristates, so we are going to use base3 gpio reads, which also follows what we are using for trogdor board id.
Signed-off-by: Shelley Chen shchen@google.com Change-Id: I99158a01862f8d9560664cd15714513b42ac7c84 --- M src/mainboard/google/herobrine/boardid.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/57024/1
diff --git a/src/mainboard/google/herobrine/boardid.c b/src/mainboard/google/herobrine/boardid.c index e92d1ef9c..9290d92 100644 --- a/src/mainboard/google/herobrine/boardid.c +++ b/src/mainboard/google/herobrine/boardid.c @@ -15,7 +15,7 @@ const gpio_t pins[] = {[2] = GPIO(75), [1] = GPIO(74), [0] = GPIO(73)};
if (id == UNDEFINED_STRAPPING_ID) - id = gpio_pulldown_base2_value(pins, ARRAY_SIZE(pins)); + id = gpio_base3_value(pins, ARRAY_SIZE(pins));
if ((id == QCOM_SC7280_SKU1) || (id == QCOM_SC7280_SKU2) || (id == QCOM_SC7280_SKU3))