Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74447 )
Change subject: soc/intel/braswell: Replace <build.h> with <version.h> ......................................................................
soc/intel/braswell: Replace <build.h> with <version.h>
To use generated build.h one should have had a pre-requisite in the Makefile. Reference coreboot_build_date from lib/version.c instead.
Change-Id: Icd6fa2ddf8aa584b0f51ba130592f227bbdad975 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/74447 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/intel/braswell/bootblock/bootblock.c 1 file changed, 21 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved
diff --git a/src/soc/intel/braswell/bootblock/bootblock.c b/src/soc/intel/braswell/bootblock/bootblock.c index 2c9783a..8ab95ef 100644 --- a/src/soc/intel/braswell/bootblock/bootblock.c +++ b/src/soc/intel/braswell/bootblock/bootblock.c @@ -2,7 +2,6 @@
#include <arch/io.h> #include <bootblock_common.h> -#include <build.h> #include <console/console.h> #include <device/pci_ops.h> #include <fsp/util.h> @@ -14,6 +13,7 @@ #include <soc/msr.h> #include <soc/pm.h> #include <soc/spi.h> +#include <version.h>
asmlinkage void bootblock_c_entry(uint64_t base_timestamp) { @@ -79,11 +79,10 @@ { int rtc_failed = rtc_failure();
- if (rtc_failed) { + if (rtc_failed) printk(BIOS_ERR, "RTC Failure detected. Resetting date to %x/%x/%x%x\n", - COREBOOT_BUILD_MONTH_BCD, COREBOOT_BUILD_DAY_BCD, 0x20, - COREBOOT_BUILD_YEAR_BCD); - } + coreboot_build_date.month, coreboot_build_date.day, + coreboot_build_date.century, coreboot_build_date.year);
cmos_init(rtc_failed); }