Attention is currently required from: Ashish Kumar Mishra, Felix Held, Paul Menzel, Subrata Banik.
Saurabh Mishra has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83419?usp=email )
Change subject: mb/google/fatcat: Add Panther Lake SOC support
......................................................................
Patch Set 4:
(5 comments)
File src/mainboard/google/fatcat/Kconfig:
https://review.coreboot.org/c/coreboot/+/83419/comment/029a4439_fc252b76?usp... :
PS4, Line 29: SOC_INTEL_IOE_DIE_SUPPORT
we should keep this to ensure P2SB#2 support exists
Acknowledged
https://review.coreboot.org/c/coreboot/+/83419/comment/afff6cc0_61e18865?usp... :
PS4, Line 13: if !SIMICS_ENV
please drop the simics support. […]
Sure. Dropping Simics support for Fatcat.
https://review.coreboot.org/c/coreboot/+/83419/comment/04660a40_efe8392f?usp... :
PS4, Line 16: DRIVERS_UART_8250IO
this is non-POR for chrome board
Acknowledged
https://review.coreboot.org/c/coreboot/+/83419/comment/cc7bc184_62e24c3e?usp... :
PS4, Line 30: SOC_INTEL_PANTHERLAKE_A0
SOC_INTEL_PANTHERLAKE_U_H
Acknowledged
https://review.coreboot.org/c/coreboot/+/83419/comment/73eaa643_07fbdb2c?usp... :
PS4, Line 108: config SIMICS_ENV
: default y
:
drop this as we don't need, plus the Kconfig implementation itself is not correct […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83419?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5e
Gerrit-Change-Number: 83419
Gerrit-PatchSet: 4
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 23 Jul 2024 12:27:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com