Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42868 )
Change subject: soc/amd/common/gpio: Drop unused macro GPIO_TRIGGER_INVALID ......................................................................
soc/amd/common/gpio: Drop unused macro GPIO_TRIGGER_INVALID
This change drops unused macro GPIO_TRIGGER_VALID from gpio_banks.h.
BUG=b:159944426
Change-Id: Ie115f37893d9ba190bab56cf8b037febd8b5f4b5 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/soc/amd/common/block/include/amdblocks/gpio_banks.h 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/42868/1
diff --git a/src/soc/amd/common/block/include/amdblocks/gpio_banks.h b/src/soc/amd/common/block/include/amdblocks/gpio_banks.h index 4a8a5ae..92aa8a2 100644 --- a/src/soc/amd/common/block/include/amdblocks/gpio_banks.h +++ b/src/soc/amd/common/block/include/amdblocks/gpio_banks.h @@ -113,8 +113,6 @@ GPIO_TRIGGER_EDGE_HIGH, };
-#define GPIO_TRIGGER_INVALID -1 - #define GPIO_SPECIAL_FLAG (1 << 31) #define GPIO_DEBOUNCE_FLAG (1 << 30) #define GPIO_WAKE_FLAG (1 << 29)
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42868 )
Change subject: soc/amd/common/gpio: Drop unused macro GPIO_TRIGGER_INVALID ......................................................................
Patch Set 1: Code-Review+1
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42868 )
Change subject: soc/amd/common/gpio: Drop unused macro GPIO_TRIGGER_INVALID ......................................................................
Patch Set 1: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42868 )
Change subject: soc/amd/common/gpio: Drop unused macro GPIO_TRIGGER_INVALID ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42868 )
Change subject: soc/amd/common/gpio: Drop unused macro GPIO_TRIGGER_INVALID ......................................................................
soc/amd/common/gpio: Drop unused macro GPIO_TRIGGER_INVALID
This change drops unused macro GPIO_TRIGGER_VALID from gpio_banks.h.
BUG=b:159944426
Change-Id: Ie115f37893d9ba190bab56cf8b037febd8b5f4b5 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42868 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/soc/amd/common/block/include/amdblocks/gpio_banks.h 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Aaron Durbin: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/common/block/include/amdblocks/gpio_banks.h b/src/soc/amd/common/block/include/amdblocks/gpio_banks.h index 4a8a5ae..92aa8a2 100644 --- a/src/soc/amd/common/block/include/amdblocks/gpio_banks.h +++ b/src/soc/amd/common/block/include/amdblocks/gpio_banks.h @@ -113,8 +113,6 @@ GPIO_TRIGGER_EDGE_HIGH, };
-#define GPIO_TRIGGER_INVALID -1 - #define GPIO_SPECIAL_FLAG (1 << 31) #define GPIO_DEBOUNCE_FLAG (1 << 30) #define GPIO_WAKE_FLAG (1 << 29)