Change in coreboot[master]: nb/intel/ironlake: Factor out common uncore ASL

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55580 )

Change subject: nb/intel/ironlake: Factor out common uncore ASL
......................................................................

nb/intel/ironlake: Factor out common uncore ASL

Tested with BUILD_TIMELESS=1, Packard Bell MS2290 remains identical.

Change-Id: I7e37d32251fa3dcc64aec62dd2d814463c4a9999
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55580
Reviewed-by: Patrick Georgi 
Reviewed-by: Arthur Heymans 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/lenovo/t410/dsdt.asl
M src/mainboard/lenovo/x201/dsdt.asl
M src/mainboard/packardbell/ms2290/dsdt.asl
A src/northbridge/intel/ironlake/acpi/uncore.asl
4 files changed, 38 insertions(+), 99 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Arthur Heymans: Looks good to me, approved

diff --git a/src/mainboard/lenovo/t410/dsdt.asl b/src/mainboard/lenovo/t410/dsdt.asl
index 43c7b62..42a10e6 100644
--- a/src/mainboard/lenovo/t410/dsdt.asl
+++ b/src/mainboard/lenovo/t410/dsdt.asl
@@ -36,39 +36,7 @@

#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
    	}
-		Device (UNCR)
-		{
-			Name (_BBN, 0xFF)
-			Name (RID, 0x00)
-			Name (_HID, EisaId ("PNP0A03"))
-			Name (_CRS, ResourceTemplate ()
-				{
-				WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
-						0x0000,	     /* Granularity */
-						0x00FF,	     /* Range Minimum */
-						0x00FF,	     /* Range Maximum */
-						0x0000,	     /* Translation Offset */
-						0x0001,	     /* Length */
-						,, )
-				})
-			Device (SAD)
-			{
-				Name (_ADR, 0x01)
-				Name (RID, 0x00)
-				OperationRegion (SADC, PCI_Config, 0x00, 0x0100)
-				Field (SADC, DWordAcc, NoLock, Preserve)
-				{
-					Offset (0x40),
-					PAM0,   8,
-					PAM1,   8,
-					PAM2,   8,
-					PAM3,   8,
-					PAM4,   8,
-					PAM5,   8,
-					PAM6,   8
-				}
-			}
-		}
+		#include <northbridge/intel/ironlake/acpi/uncore.asl>
    }

#include <southbridge/intel/common/acpi/sleepstates.asl>
diff --git a/src/mainboard/lenovo/x201/dsdt.asl b/src/mainboard/lenovo/x201/dsdt.asl
index 43c7b62..42a10e6 100644
--- a/src/mainboard/lenovo/x201/dsdt.asl
+++ b/src/mainboard/lenovo/x201/dsdt.asl
@@ -36,39 +36,7 @@

#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
    	}
-		Device (UNCR)
-		{
-			Name (_BBN, 0xFF)
-			Name (RID, 0x00)
-			Name (_HID, EisaId ("PNP0A03"))
-			Name (_CRS, ResourceTemplate ()
-				{
-				WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
-						0x0000,	     /* Granularity */
-						0x00FF,	     /* Range Minimum */
-						0x00FF,	     /* Range Maximum */
-						0x0000,	     /* Translation Offset */
-						0x0001,	     /* Length */
-						,, )
-				})
-			Device (SAD)
-			{
-				Name (_ADR, 0x01)
-				Name (RID, 0x00)
-				OperationRegion (SADC, PCI_Config, 0x00, 0x0100)
-				Field (SADC, DWordAcc, NoLock, Preserve)
-				{
-					Offset (0x40),
-					PAM0,   8,
-					PAM1,   8,
-					PAM2,   8,
-					PAM3,   8,
-					PAM4,   8,
-					PAM5,   8,
-					PAM6,   8
-				}
-			}
-		}
+		#include <northbridge/intel/ironlake/acpi/uncore.asl>
    }

#include <southbridge/intel/common/acpi/sleepstates.asl>
diff --git a/src/mainboard/packardbell/ms2290/dsdt.asl b/src/mainboard/packardbell/ms2290/dsdt.asl
index 0fa2cc0..187c55a 100644
--- a/src/mainboard/packardbell/ms2290/dsdt.asl
+++ b/src/mainboard/packardbell/ms2290/dsdt.asl
@@ -31,39 +31,7 @@

#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
    	}
-		Device (UNCR)
-		{
-			Name (_BBN, 0xFF)
-			Name (RID, 0x00)
-			Name (_HID, EisaId ("PNP0A03"))
-			Name (_CRS, ResourceTemplate ()
-				{
-				WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
-						0x0000,	     /* Granularity */
-						0x00FF,	     /* Range Minimum */
-						0x00FF,	     /* Range Maximum */
-						0x0000,	     /* Translation Offset */
-						0x0001,	     /* Length */
-						,, )
-				})
-			Device (SAD)
-			{
-				Name (_ADR, 0x01)
-				Name (RID, 0x00)
-				OperationRegion (SADC, PCI_Config, 0x00, 0x0100)
-				Field (SADC, DWordAcc, NoLock, Preserve)
-				{
-					Offset (0x40),
-					PAM0,   8,
-					PAM1,   8,
-					PAM2,   8,
-					PAM3,   8,
-					PAM4,   8,
-					PAM5,   8,
-					PAM6,   8
-				}
-			}
-		}
+		#include <northbridge/intel/ironlake/acpi/uncore.asl>
    }

#include <southbridge/intel/common/acpi/sleepstates.asl>
diff --git a/src/northbridge/intel/ironlake/acpi/uncore.asl b/src/northbridge/intel/ironlake/acpi/uncore.asl
new file mode 100644
index 0000000..042ab84
--- /dev/null
+++ b/src/northbridge/intel/ironlake/acpi/uncore.asl
@@ -0,0 +1,35 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+Device (UNCR)
+{
+	Name (_BBN, 0xFF)
+	Name (RID, 0x00)
+	Name (_HID, EisaId ("PNP0A03"))
+	Name (_CRS, ResourceTemplate ()
+		{
+		WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
+				0x0000,	     /* Granularity */
+				0x00FF,	     /* Range Minimum */
+				0x00FF,	     /* Range Maximum */
+				0x0000,	     /* Translation Offset */
+				0x0001,	     /* Length */
+				,, )
+		})
+	Device (SAD)
+	{
+		Name (_ADR, 0x01)
+		Name (RID, 0x00)
+		OperationRegion (SADC, PCI_Config, 0x00, 0x0100)
+		Field (SADC, DWordAcc, NoLock, Preserve)
+		{
+			Offset (0x40),
+			PAM0,   8,
+			PAM1,   8,
+			PAM2,   8,
+			PAM3,   8,
+			PAM4,   8,
+			PAM5,   8,
+			PAM6,   8
+		}
+	}
+}