Change in coreboot[master]: mb/google/dedede/var/drawcia: Probe and enable DPTF configuration
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47010 )
Change subject: mb/google/dedede/var/drawcia: Probe and enable DPTF configuration ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47010/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47010/5/src/mainboard/google/dedede... PS5, Line 95: 65
After comparison of existing and these new added entries, observed that only this temperature trip v […]
Yes that is correct. I could have moved the difference into a .C file to override only that passive policy. But I am afraid, developers may not notice it and that will lead to more confusion. Hence added it in the device tree so that it will be more clear.
https://review.coreboot.org/c/coreboot/+/47010/5/src/mainboard/google/dedede... PS5, Line 139: # Default DPTF Policy for all drawcia boards if not overridden : register "options.tsr[0].desc" = ""Memory"" : register "options.tsr[1].desc" = ""Ambient"" : register "options.tsr[2].desc" = ""Charger"" : register "options.tsr[3].desc" = ""5V regulator""
Is it possible to define these sensor description entries only once, instead of keeping for both the […]
I may be wrong, but I am not aware of any such option.
Do you see any issue moving the TSR1 trip value to 65 for the devices of all form factors. If so, then I am fine with moving to that value. That way we don't have to duplicate the common entries.
-
Karthik Ramasubramanian (Code Review)