Attention is currently required from: Nico Huber, Michał Żygowski, Paul Menzel, Arthur Heymans.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61682 )
Change subject: nb/amd/common: Move RAM calcualtion to common code
......................................................................
Patch Set 5:
(3 comments)
File src/northbridge/amd/common/ram_calc.c:
https://review.coreboot.org/c/coreboot/+/61682/comment/1c8c89f8_0427fca4
PS5, Line 28: >
Should this be >= ?
No, this is correct, and comment in line #25 is wrong. Updated
https://review.coreboot.org/c/coreboot/+/61682/comment/5fe7b627_f3ac4c1f
PS5, Line 42:
nit: double spaces.
Done
https://review.coreboot.org/c/coreboot/+/61682/comment/5d632be4_6274f1d0
PS5, Line 50: *limitk += 1; /* round up last byte for northbridge resource calculation convenience */
: *limitk /= KiB; /* Normalize to KiB */
I think you need /= KiB first and then += 1.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61682
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d222f6cbd26fe78d968d2883984f25e8b62ab5c
Gerrit-Change-Number: 61682
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 12 Apr 2022 13:47:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment