Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Chhao Chang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84025?usp=email )
Change subject: soc/mediatek/mt8196: Add unmask eint event for bootblock ......................................................................
Patch Set 14: Code-Review+1
(4 comments)
Patchset:
PS14: The folder pach will be removed and will be implemented on the kernel side
File src/soc/mediatek/common/eint_event.c:
https://review.coreboot.org/c/coreboot/+/84025/comment/3dbced6a_a99a71a2?usp... : PS14, Line 10: 0x880
If this is shared with mt8196, please add `#define EINT_EVENT_MASK_CLEAR_OFFSET 0x880` to eint_event […]
The folder pach will be removed and will be implemented on the kernel side
File src/soc/mediatek/mt8196/eint_event.c:
https://review.coreboot.org/c/coreboot/+/84025/comment/f8b905cb_e8dbb40a?usp... : PS14, Line 16: static void eint_clear_event_mask(uintptr_t base, unsigned int port_num)
More precisely: […]
The folder pach will be removed and will be implemented on the kernel side
https://review.coreboot.org/c/coreboot/+/84025/comment/54cd8c02_ccfa7081?usp... : PS14, Line 26: eint_clear_event_mask(EINT_E_BASE, MAX_E);
Define an array of pairs `(base, port_num)` and use a for loop.
The folder pach will be removed and will be implemented on the kernel side