Attention is currently required from: Robert Chen, Shou-Chieh Hsu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74307 )
Change subject: mb/google/dedede/var/kracko: Add G2touch touchscreen support for Kracko
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74307/comment/0d3e0e89_9af92bf0
PS5, Line 7: for Kracko
Redundant as also present in prefix.
https://review.coreboot.org/c/coreboot/+/74307/comment/8ad6365e_1a3a9b65
PS5, Line 9: Add G2touch touchscreen support for kracko OOC panel.
What is OOC?
https://review.coreboot.org/c/coreboot/+/74307/comment/abbf56cb_cdf227cc
PS5, Line 10:
Please document the datasheet name and revision.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74307
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic065d5dc2900c6ccfee09031f7a80cefc391f5dd
Gerrit-Change-Number: 74307
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Wed, 12 Apr 2023 08:01:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment