Change in ...coreboot[master]: mb/google/kohaku: Correct trackpad i2c address

[shkim (Code Review)]

Hello Seunghwan Kim,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/33798

to review the following change.

Change subject: mb/google/kohaku: Correct trackpad i2c address
......................................................................

mb/google/kohaku: Correct trackpad i2c address

Correct i2c address of trackpad. It should be 0x20.

BUG=None
BRANCH=None
TEST=Verified trackpad works on pre-evt system

Change-Id: I7ded21ce8ff9e907e436777a27edb4273512011d
Signed-off-by: Seunghwan Kim 
---
M src/mainboard/google/hatch/variants/kohaku/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/33798/1

diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb
index 9546420..21475cb 100644
--- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb
@@ -70,7 +70,7 @@
    			register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D21_IRQ)"
    			register "generic.probed" = "1"
    			register "hid_desc_reg_offset" = "0x20"
-				device i2c 0x2c on end
+				device i2c 0x20 on end
    		end
    	end # I2C 0

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33798 )

Change subject: mb/google/kohaku: Correct trackpad i2c address
......................................................................

Patch Set 1: Code-Review+2

[Shelley Chen (Code Review)]

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33798 )

Change subject: mb/google/kohaku: Correct trackpad i2c address
......................................................................

Patch Set 1: Code-Review+2

[Shelley Chen (Code Review)]

Shelley Chen has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33798 )

Change subject: mb/google/kohaku: Correct trackpad i2c address
......................................................................

mb/google/kohaku: Correct trackpad i2c address

Correct i2c address of trackpad. It should be 0x20.

BUG=None
BRANCH=None
TEST=Verified trackpad works on pre-evt system

Change-Id: I7ded21ce8ff9e907e436777a27edb4273512011d
Signed-off-by: Seunghwan Kim 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33798
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Shelley Chen 
---
M src/mainboard/google/hatch/variants/kohaku/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Shelley Chen: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb
index 69875bd..cf422ed 100644
--- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb
@@ -70,7 +70,7 @@
    			register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D21_IRQ)"
    			register "generic.probed" = "1"
    			register "hid_desc_reg_offset" = "0x20"
-				device i2c 0x2c on end
+				device i2c 0x20 on end
    		end
    	end # I2C 0