Change in ...coreboot[master]: mb/google/arcada: Update USB2 port6 AFE setting

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Lijian Zhao (Code Review)

27 Feb 2019 27 Feb '19

5:14 a.m.

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31632

Change subject: mb/google/arcada: Update USB2 port6 AFE setting ......................................................................

mb/google/arcada: Update USB2 port6 AFE setting

Accoriding to 574354, we need to tune each port to pass eye diagram other than just use recommanded setting as they are base guidence only.

Bug=b:124407280 TEST=Build and boot up on sarien board.

Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I587695809b368edd33852c4241de097ca31e9d66 --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 8 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/31632/1

diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 244ba7a..cded5ff 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -125,7 +125,14 @@ register "usb2_ports[3]" = "USB2_PORT_EMPTY" register "usb2_ports[4]" = "USB2_PORT_EMPTY" register "usb2_ports[5]" = "USB2_PORT_LONG(OC_SKIP)" # Camera - register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" # WWAN + register "usb2_ports[6]" = "{ + .enable = 1, \ + .ocpin = OC_SKIP, \ + .tx_bias = USB2_BIAS_0MV, \ + .tx_emp_enable = USB2_DE_EMP_ON_PRE_EMP_ON, \ + .pre_emp_bias = USB2_BIAS_28P15MV, \ + .pre_emp_bit = USB2_HALF_BIT_PRE_EMP, \ + }" # WWAN register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # USH register "usb2_ports[8]" = "USB2_PORT_MID(OC_SKIP)" # Fingerprint register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth

Attachments:

attachment.htm (text/html — 3.7 KB)

Show replies by date

Lijian Zhao (Code Review)

27 Feb 27 Feb

5:55 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31632

to look at the new patch set (#2).

Change subject: mb/google/arcada: Update USB2 port6 AFE setting ......................................................................

mb/google/arcada: Update USB2 port6 AFE setting

Accoriding to 574354, we need to tune each port to pass eye diagram other than just use recommanded setting as they are base guidence only.

Bug=b:124407280 TEST=Build and boot up on arcada board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/31632/2

Casper Chang (Code Review)

12 Mar 12 Mar

4:08 a.m.

Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31632 )

Change subject: mb/google/arcada: Update USB2 port6 AFE setting ......................................................................

Patch Set 2: Code-Review+1

SIV verify passed.

Thejaswani Putta (Code Review)

13 Mar 13 Mar

3:43 p.m.

Thejaswani Putta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31632 )

Change subject: mb/google/arcada: Update USB2 port6 AFE setting ......................................................................

Patch Set 2: Code-Review+1

Looks good to me

-- To view, visit https://review.coreboot.org/c/coreboot/+/31632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I587695809b368edd33852c4241de097ca31e9d66 Gerrit-Change-Number: 31632 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Thejaswani Putta thejaswani.putta@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 13 Mar 2019 18:43:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Lijian Zhao (Code Review)

3:47 p.m.

Lijian Zhao has removed Casper Chang from this change. ( https://review.coreboot.org/c/coreboot/+/31632 )

Change subject: mb/google/arcada: Update USB2 port6 AFE setting ......................................................................

Removed reviewer Casper Chang with the following votes:

* Code-Review+1 by Casper Chang casper_chang@wistron.corp-partner.google.com

-- To view, visit https://review.coreboot.org/c/coreboot/+/31632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I587695809b368edd33852c4241de097ca31e9d66 Gerrit-Change-Number: 31632 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Thejaswani Putta thejaswani.putta@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: deleteReviewer

Wonkyu Kim (Code Review)

3:50 p.m.

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31632 )

Change subject: mb/google/arcada: Update USB2 port6 AFE setting ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/31632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I587695809b368edd33852c4241de097ca31e9d66 Gerrit-Change-Number: 31632 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Thejaswani Putta thejaswani.putta@intel.com Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 13 Mar 2019 18:50:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

John Zhao (Code Review)

4:18 p.m.

John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31632 )

Change subject: mb/google/arcada: Update USB2 port6 AFE setting ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I587695809b368edd33852c4241de097ca31e9d66 Gerrit-Change-Number: 31632 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: John Zhao john.zhao@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Thejaswani Putta thejaswani.putta@intel.com Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 13 Mar 2019 19:18:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Lijian Zhao (Code Review)

8:16 p.m.

Hello Thejaswani Putta, Wonkyu Kim, John Zhao, Duncan Laurie, Bora Guvendik, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31632

to look at the new patch set (#3).

Change subject: mb/google/arcada: Update USB2 port6 AFE setting ......................................................................

mb/google/arcada: Update USB2 port6 AFE setting

Accoriding to 574354, we need to tune each port to pass eye diagram other than just use recommanded setting as they are base guidence only.

Bug=b:124407280 TEST=Build and boot up on arcada board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/31632/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/31632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I587695809b368edd33852c4241de097ca31e9d66 Gerrit-Change-Number: 31632 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: John Zhao john.zhao@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Thejaswani Putta thejaswani.putta@intel.com Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Pratikkumar V Prajapati (Code Review)

8:17 p.m.

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31632 )

Change subject: mb/google/arcada: Update USB2 port6 AFE setting ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I587695809b368edd33852c4241de097ca31e9d66 Gerrit-Change-Number: 31632 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: John Zhao john.zhao@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Pratikkumar V Prajapati pratikkumar.v.prajapati@intel.com Gerrit-Reviewer: Thejaswani Putta thejaswani.putta@intel.com Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 13 Mar 2019 23:17:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Duncan Laurie (Code Review)

8:54 p.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31632 )

Change subject: mb/google/arcada: Update USB2 port6 AFE setting ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I587695809b368edd33852c4241de097ca31e9d66 Gerrit-Change-Number: 31632 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: John Zhao john.zhao@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Pratikkumar V Prajapati pratikkumar.v.prajapati@intel.com Gerrit-Reviewer: Thejaswani Putta thejaswani.putta@intel.com Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 13 Mar 2019 23:54:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

14 Mar 14 Mar

8:48 a.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31632 )

Change subject: mb/google/arcada: Update USB2 port6 AFE setting ......................................................................

mb/google/arcada: Update USB2 port6 AFE setting

Accoriding to 574354, we need to tune each port to pass eye diagram other than just use recommanded setting as they are base guidence only.

Bug=b:124407280 TEST=Build and boot up on arcada board.

Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I587695809b368edd33852c4241de097ca31e9d66 Reviewed-on: https://review.coreboot.org/c/coreboot/+/31632 Reviewed-by: Pratikkumar V Prajapati pratikkumar.v.prajapati@intel.com Reviewed-by: Duncan Laurie dlaurie@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 8 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Pratikkumar V Prajapati: Looks good to me, approved

diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index c966e9a..c0411e1 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -125,7 +125,14 @@ register "usb2_ports[3]" = "USB2_PORT_EMPTY" register "usb2_ports[4]" = "USB2_PORT_EMPTY" register "usb2_ports[5]" = "USB2_PORT_LONG(OC_SKIP)" # Camera - register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" # WWAN + register "usb2_ports[6]" = "{ + .enable = 1, \ + .ocpin = OC_SKIP, \ + .tx_bias = USB2_BIAS_0MV, \ + .tx_emp_enable = USB2_DE_EMP_ON_PRE_EMP_ON, \ + .pre_emp_bias = USB2_BIAS_28P15MV, \ + .pre_emp_bit = USB2_HALF_BIT_PRE_EMP, \ + }" # WWAN register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # USH register "usb2_ports[8]" = "USB2_PORT_MID(OC_SKIP)" # Fingerprint register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth

-- To view, visit https://review.coreboot.org/c/coreboot/+/31632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I587695809b368edd33852c4241de097ca31e9d66 Gerrit-Change-Number: 31632 Gerrit-PatchSet: 4 Gerrit-Owner: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: John Zhao john.zhao@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Pratikkumar V Prajapati pratikkumar.v.prajapati@intel.com Gerrit-Reviewer: Thejaswani Putta thejaswani.putta@intel.com Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1938

days inactive

1953

days old

coreboot-gerrit@coreboot.org

10 comments

8 participants

tags (0)

participants (8)

Casper Chang (Code Review)
Duncan Laurie (Code Review)
John Zhao (Code Review)
Lijian Zhao (Code Review)
Patrick Georgi (Code Review)
Pratikkumar V Prajapati (Code Review)
Thejaswani Putta (Code Review)
Wonkyu Kim (Code Review)