Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Hannah Williams.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84103?usp=email )
Change subject: soc/intel/common/block/acpi: Add GPE1 blocks to ACPI FADT table ......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/84103/comment/41550560_3b021875?usp... : PS5, Line 114: GPE1_STS(0)
Subrata,
I will need to use #if instead. I got this error if GPE1_STS macro is not defined.
src/soc/intel/common/block/acpi/acpi.c:110:84: error: implicit declaration of function 'GPE1_STS'; did you mean 'GPE0_STS'? [-Werror=implicit-function-declaration] 110 | fadt->gpe1_blk = CONFIG(SOC_INTEL_COMMON_BLOCK_ACPI_USE_GPE1) ? (pmbase + GPE1_STS(0)) : GPE1_STS(0); | ^~~~~~~~
any thought? let me switch for the next patchset first.
for this reason only i have told to add below code in all SoC directory
``` /* Platform doesn't have support for GPE1, adding dummy entry for common code */ #define GPE1_STS(x) (0x0 + ((x) * 4)) ```