[XS] Change in coreboot[main]: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67

[Angel Pons (Code Review)]

Attention is currently required from: Elyes Haouas, Felix Singer, Pratikkumar V Prajapati.

Angel Pons has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83110?usp=email )

Change subject: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67
......................................................................

Patch Set 2: Code-Review-1

(2 comments)

File util/inteltool/lpc.c:

https://review.coreboot.org/c/coreboot/+/83110/comment/9c24ab8b_4fbef1dc?usp... :
PS1, Line 90: 	case PCI_DEVICE_ID_INTEL_H67:
> looks better to me

I am not sure if I understand you correctly. Are you saying that **NOT** adding some more `case PCI_DEVICE_ID_INTEL_*:` lines for CPT (Cougar Point, aka 6 series PCH) "looks better to you"?

https://review.coreboot.org/c/coreboot/+/83110/comment/04d758a8_6ad755be?usp... :
PS1, Line 120: 		bc = pci_read_long(dev, SUNRISE_LPC_BC);
> Out of scope of current patch

It definitely is in scope of this patch. The bit you are checking has a different meaning in CPT (Cougar Point, aka 6 series PCH): https://i.imgur.com/joVk40u.png

This is not the only difference. Here is the full datasheet for your hardware: https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/6-ch...