Attention is currently required from: Felix Held, Jason Nein, Jason Nien, Martin Roth, Matt DeVillier.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80237?usp=email )
Change subject: mb/google/guybrush: turn off SD ASPM L1.1/L1.2
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80237/comment/da7dfc4d_a64ddb0d :
PS1, Line 9: turn off SD ASPM L1.1/L1.2 as w/a for wlan DMA resume failure
Are there any guesses as to why the SD PCIe bus is able to affect the WLAN DMA? How are the two busses affecting each other?
https://review.coreboot.org/c/coreboot/+/80237/comment/0e54ac5c_6fa307f2 :
PS1, Line 12: TEST=test pass over 10k cycles
Please also measure the power impact of this change. You can use the following CL as an example:
https://review.coreboot.org/c/coreboot/+/77963
Patchset:
PS1:
As noted by the build bot, please use the `main` branch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80237?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d903f0f6333ffa18069e42be3c932aeae8013d9
Gerrit-Change-Number: 80237
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Nein
finaljason@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Jason Nein
finaljason@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 30 Jan 2024 00:26:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment