Attention is currently required from: Paul Menzel, mturney mturney, Ravi Kumar Bokka, Sudheer Amrabadi, Julius Werner, Angel Pons. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60805 )
Change subject: mb/google/herobrine: Fix board id ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60805/comment/af942af7_847160c4 PS2, Line 9: The board id assignment CL (CB:56642)
Please mention the commit hash and commit message summary.
Done
https://review.coreboot.org/c/coreboot/+/60805/comment/0f793fff_39ff3502 PS2, Line 9: The board id assignment CL (CB:56642) landed after : BOARD_GOOGLE_HEROBRINE has been deprecated to : BOARD_GOOGLE_HEROBRINE_REV0
… in commit <hash> (<commit message summary>)
Done
https://review.coreboot.org/c/coreboot/+/60805/comment/8f57e463_900e15fa PS2, Line 11: Fixing
Maybe: Fix it
Done
https://review.coreboot.org/c/coreboot/+/60805/comment/1cd622fe_4d1f9b7e PS2, Line 12: Also fixed a couple of variables : that were declared static when they didn't need to be (they are being : reinitialized at the beginning of each function anyway).
Please make that a separate commit.
Done. See CB:60806
-
Shelley Chen (Code Review)