Change in ...coreboot[master]: src/southbridge: Use 'include <stdlib.h>' when appropriate
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33683
Change subject: src/southbridge: Use 'include <stdlib.h>' when appropriate ......................................................................
src/southbridge: Use 'include <stdlib.h>' when appropriate
Change-Id: I7e1a3483aae0e3f0a7bc2eb2c1862ae7a325fd9c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/sm.c M src/southbridge/amd/cimx/sb800/smbus_spd.c M src/southbridge/amd/cimx/sb800/spi.c M src/southbridge/amd/pi/hudson/sm.c M src/southbridge/amd/sb700/sm.c M src/southbridge/amd/sb700/spi.c M src/southbridge/amd/sb800/sm.c M src/southbridge/intel/lynxpoint/me_9.x.c 8 files changed, 8 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/33683/1
diff --git a/src/southbridge/amd/agesa/hudson/sm.c b/src/southbridge/amd/agesa/hudson/sm.c index 46eca33..92bb5c1 100644 --- a/src/southbridge/amd/agesa/hudson/sm.c +++ b/src/southbridge/amd/agesa/hudson/sm.c @@ -20,7 +20,7 @@ #include <device/smbus.h> #include <cpu/x86/lapic.h> #include <arch/ioapic.h> -#include <stdlib.h> + #include "hudson.h" #include "smbus.c"
diff --git a/src/southbridge/amd/cimx/sb800/smbus_spd.c b/src/southbridge/amd/cimx/sb800/smbus_spd.c index a6881bb..a574072 100644 --- a/src/southbridge/amd/cimx/sb800/smbus_spd.c +++ b/src/southbridge/amd/cimx/sb800/smbus_spd.c @@ -15,7 +15,7 @@
#include <device/pci_def.h> #include <device/device.h> -#include <stdlib.h> +#include <stddef.h> #include <OEM.h> /* SMBUS0_BASE_ADDRESS */
/* warning: Porting.h includes an open #pragma pack(1) */ diff --git a/src/southbridge/amd/cimx/sb800/spi.c b/src/southbridge/amd/cimx/sb800/spi.c index ffda0a8..d17f99f 100644 --- a/src/southbridge/amd/cimx/sb800/spi.c +++ b/src/southbridge/amd/cimx/sb800/spi.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */ #include <stdint.h> -#include <stdlib.h> #include <device/mmio.h> #include <console/console.h> #include <spi_flash.h> @@ -21,6 +20,7 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> +#include <stddef.h>
#include "SBPLATFORM.h" #include <vendorcode/amd/cimx/sb800/ECfan.h> diff --git a/src/southbridge/amd/pi/hudson/sm.c b/src/southbridge/amd/pi/hudson/sm.c index 0387567..0b4cee7 100644 --- a/src/southbridge/amd/pi/hudson/sm.c +++ b/src/southbridge/amd/pi/hudson/sm.c @@ -20,7 +20,7 @@ #include <device/smbus.h> #include <cpu/x86/lapic.h> #include <arch/ioapic.h> -#include <stdlib.h> + #include "hudson.h" #include "smbus.c"
diff --git a/src/southbridge/amd/sb700/sm.c b/src/southbridge/amd/sb700/sm.c index 6631682..535e5e4 100644 --- a/src/southbridge/amd/sb700/sm.c +++ b/src/southbridge/amd/sb700/sm.c @@ -24,7 +24,7 @@ #include <arch/io.h> #include <cpu/x86/lapic.h> #include <arch/ioapic.h> -#include <stdlib.h> + #include "sb700.h" #include "smbus.h"
diff --git a/src/southbridge/amd/sb700/spi.c b/src/southbridge/amd/sb700/spi.c index ee031e9..4c0cc68 100644 --- a/src/southbridge/amd/sb700/spi.c +++ b/src/southbridge/amd/sb700/spi.c @@ -15,7 +15,6 @@ */
#include <stdint.h> -#include <stdlib.h> #include <device/mmio.h> #include <console/console.h> #include <spi-generic.h> @@ -23,6 +22,7 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> +#include <stddef.h>
#define AMD_SB_SPI_TX_LEN 8
diff --git a/src/southbridge/amd/sb800/sm.c b/src/southbridge/amd/sb800/sm.c index 1d2daed8..e1cf05c 100644 --- a/src/southbridge/amd/sb800/sm.c +++ b/src/southbridge/amd/sb800/sm.c @@ -23,7 +23,7 @@ #include <arch/io.h> #include <cpu/x86/lapic.h> #include <arch/ioapic.h> -#include <stdlib.h> + #include "sb800.h" #include "smbus.c"
diff --git a/src/southbridge/intel/lynxpoint/me_9.x.c b/src/southbridge/intel/lynxpoint/me_9.x.c index 09eeff2..1b77aff 100644 --- a/src/southbridge/intel/lynxpoint/me_9.x.c +++ b/src/southbridge/intel/lynxpoint/me_9.x.c @@ -34,6 +34,7 @@ #include <delay.h> #include <elog.h> #include <halt.h> +#include <stdlib.h>
#include "me.h" #include "pch.h"
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33683
to look at the new patch set (#4).
Change subject: src/southbridge: Use 'include <stdlib.h>' when appropriate ......................................................................
src/southbridge: Use 'include <stdlib.h>' when appropriate
Also, including <types.h>, is supposed to provide stdint and stddef.
Change-Id: I7e1a3483aae0e3f0a7bc2eb2c1862ae7a325fd9c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/sm.c M src/southbridge/amd/cimx/sb800/smbus_spd.c M src/southbridge/amd/cimx/sb800/spi.c M src/southbridge/amd/pi/hudson/sm.c M src/southbridge/amd/sb700/sm.c M src/southbridge/amd/sb700/spi.c M src/southbridge/amd/sb800/sm.c M src/southbridge/intel/lynxpoint/me_9.x.c 8 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/33683/4
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33683 )
Change subject: src/southbridge: Use 'include <stdlib.h>' when appropriate ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33683 )
Change subject: src/southbridge: Use 'include <stdlib.h>' when appropriate ......................................................................
src/southbridge: Use 'include <stdlib.h>' when appropriate
Also, including <types.h>, is supposed to provide stdint and stddef.
Change-Id: I7e1a3483aae0e3f0a7bc2eb2c1862ae7a325fd9c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33683 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/southbridge/amd/agesa/hudson/sm.c M src/southbridge/amd/cimx/sb800/smbus_spd.c M src/southbridge/amd/cimx/sb800/spi.c M src/southbridge/amd/pi/hudson/sm.c M src/southbridge/amd/sb700/sm.c M src/southbridge/amd/sb700/spi.c M src/southbridge/amd/sb800/sm.c M src/southbridge/intel/lynxpoint/me_9.x.c 8 files changed, 9 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/southbridge/amd/agesa/hudson/sm.c b/src/southbridge/amd/agesa/hudson/sm.c index b5739f9..07646c8 100644 --- a/src/southbridge/amd/agesa/hudson/sm.c +++ b/src/southbridge/amd/agesa/hudson/sm.c @@ -19,7 +19,7 @@ #include <device/smbus.h> #include <cpu/x86/lapic.h> #include <arch/ioapic.h> -#include <stdlib.h> + #include "hudson.h" #include "smbus.c"
diff --git a/src/southbridge/amd/cimx/sb800/smbus_spd.c b/src/southbridge/amd/cimx/sb800/smbus_spd.c index a6881bb..a574072 100644 --- a/src/southbridge/amd/cimx/sb800/smbus_spd.c +++ b/src/southbridge/amd/cimx/sb800/smbus_spd.c @@ -15,7 +15,7 @@
#include <device/pci_def.h> #include <device/device.h> -#include <stdlib.h> +#include <stddef.h> #include <OEM.h> /* SMBUS0_BASE_ADDRESS */
/* warning: Porting.h includes an open #pragma pack(1) */ diff --git a/src/southbridge/amd/cimx/sb800/spi.c b/src/southbridge/amd/cimx/sb800/spi.c index ffda0a8..fcb4fa1 100644 --- a/src/southbridge/amd/cimx/sb800/spi.c +++ b/src/southbridge/amd/cimx/sb800/spi.c @@ -12,8 +12,7 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ -#include <stdint.h> -#include <stdlib.h> + #include <device/mmio.h> #include <console/console.h> #include <spi_flash.h> @@ -21,6 +20,7 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> +#include <types.h>
#include "SBPLATFORM.h" #include <vendorcode/amd/cimx/sb800/ECfan.h> diff --git a/src/southbridge/amd/pi/hudson/sm.c b/src/southbridge/amd/pi/hudson/sm.c index 58f5113..7ecb8df 100644 --- a/src/southbridge/amd/pi/hudson/sm.c +++ b/src/southbridge/amd/pi/hudson/sm.c @@ -19,7 +19,7 @@ #include <device/smbus.h> #include <cpu/x86/lapic.h> #include <arch/ioapic.h> -#include <stdlib.h> + #include "hudson.h" #include "smbus.c"
diff --git a/src/southbridge/amd/sb700/sm.c b/src/southbridge/amd/sb700/sm.c index 6631682..535e5e4 100644 --- a/src/southbridge/amd/sb700/sm.c +++ b/src/southbridge/amd/sb700/sm.c @@ -24,7 +24,7 @@ #include <arch/io.h> #include <cpu/x86/lapic.h> #include <arch/ioapic.h> -#include <stdlib.h> + #include "sb700.h" #include "smbus.h"
diff --git a/src/southbridge/amd/sb700/spi.c b/src/southbridge/amd/sb700/spi.c index ee031e9..f772f75 100644 --- a/src/southbridge/amd/sb700/spi.c +++ b/src/southbridge/amd/sb700/spi.c @@ -14,8 +14,6 @@ * GNU General Public License for more details. */
-#include <stdint.h> -#include <stdlib.h> #include <device/mmio.h> #include <console/console.h> #include <spi-generic.h> @@ -23,6 +21,7 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> +#include <types.h>
#define AMD_SB_SPI_TX_LEN 8
diff --git a/src/southbridge/amd/sb800/sm.c b/src/southbridge/amd/sb800/sm.c index 1d2daed8..e1cf05c 100644 --- a/src/southbridge/amd/sb800/sm.c +++ b/src/southbridge/amd/sb800/sm.c @@ -23,7 +23,7 @@ #include <arch/io.h> #include <cpu/x86/lapic.h> #include <arch/ioapic.h> -#include <stdlib.h> + #include "sb800.h" #include "smbus.c"
diff --git a/src/southbridge/intel/lynxpoint/me_9.x.c b/src/southbridge/intel/lynxpoint/me_9.x.c index 8d86e68..b43a1ae 100644 --- a/src/southbridge/intel/lynxpoint/me_9.x.c +++ b/src/southbridge/intel/lynxpoint/me_9.x.c @@ -34,6 +34,7 @@ #include <delay.h> #include <elog.h> #include <halt.h> +#include <stdlib.h>
#include "chip.h" #include "me.h"
-
HAOUAS Elyes (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)