Change in ...coreboot[master]: vendorcode/intel/fsp/fsp2_0/cml: Add FSP header files for Cometlake
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31529 )
Change subject: vendorcode/intel/fsp/fsp2_0/cml: Add FSP header files for Cometlake ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31529/3/src/vendorcode/intel/fsp/fsp2_0/come... File src/vendorcode/intel/fsp/fsp2_0/cometlake/FspUpd.h:
https://review.coreboot.org/#/c/31529/3/src/vendorcode/intel/fsp/fsp2_0/come... PS3, Line 3: Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
i don't understand the point of this argument. […]
Were the contents of this file newly created, though?
It's an interesting statement. Even though I don't understand what an "FSP stream" is, do you mean that the copyright notice above applies to FSP as a whole and not just this file? It seems we could bikeshed if it's a derived work (as a whole), then, but hard to assess if it allows to extend the copyright.
https://review.coreboot.org/#/c/31529/3/src/vendorcode/intel/fsp/fsp2_0/come... PS3, Line 40: #define FSPT_UPD_SIGNATURE 0x545F4450554C4643 /* 'CFLUPD_T' */
this is a bug, we have already raised hence nothing much to worry. […]
Nothing to worry beside confusion, making bisecting even harder than it already is without a submodule pointer etc.
-
Nico Huber (Code Review)