HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44289 )
Change subject: nb/intel/pineview/raminit.c: Fix dead assignments ......................................................................
nb/intel/pineview/raminit.c: Fix dead assignments
Change-Id: Idf864299fbf120cb56030a9c166476d03e72ff32 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/pineview/raminit.c 1 file changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/44289/1
diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c index 43149be..7906d7b 100644 --- a/src/northbridge/intel/pineview/raminit.c +++ b/src/northbridge/intel/pineview/raminit.c @@ -2497,18 +2497,11 @@ dqdqs_out = 4382; dqdqs_outdelay = 5083; dqdqs_delay = 4692; - coretomcp = 0; - txdelay = 0; - halfclk = 0; - tmaxunmask = 0; - tmaxpi = 0; repeat = 2; feature = 0; cwb = 0; pimdclk = 0; - reg32 = 0; push = 0; - reg8 = 0;
mdclk = (s->selected_timings.mem_clock == MEM_CLOCK_667MHz) ? 3000 : 2500; refclk = 3000 - mdclk;
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44289 )
Change subject: nb/intel/pineview/raminit.c: Fix dead assignments ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44289/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44289/1//COMMIT_MSG@7 PS1, Line 7: Fix Remove
Hello Damien Zammit, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44289
to look at the new patch set (#2).
Change subject: nb/intel/pineview/raminit.c: Remove dead assignments ......................................................................
nb/intel/pineview/raminit.c: Remove dead assignments
Change-Id: Idf864299fbf120cb56030a9c166476d03e72ff32 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/pineview/raminit.c 1 file changed, 0 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/44289/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44289 )
Change subject: nb/intel/pineview/raminit.c: Remove dead assignments ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44289/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44289/1//COMMIT_MSG@7 PS1, Line 7: Fix
Remove
Done
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)