Attention is currently required from: Felix Singer, Jérémy Compostella, yuchi.chen@intel.com.
Shuo Liu has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83320?usp=email )
Change subject: soc/intel/common/block/imc: Add Integrated Memory Controller driver ......................................................................
Patch Set 17:
(3 comments)
File src/soc/intel/common/block/include/intelblocks/imc.h:
https://review.coreboot.org/c/coreboot/+/83320/comment/cf22705f_29736879?usp... : PS15, Line 10:
I moved it to an internal header imclib.h.
Done
File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/83320/comment/f4c0d837_a3eb18c4?usp... : PS7, Line 38: static void spd_read(u8 *spd, u8 addr)
This function is not the actual SPD IO function, it calls spd_read_byte(), spd_read_word() and spd_w […]
Done
File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/83320/comment/55b6641c_3e7fc342?usp... : PS15, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
Please review https://review.coreboot.org/c/coreboot/+/84201.
Done