Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Karthik Ramasubramanian, Felix Held. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59867 )
Change subject: soc/amd/cezanne: Separate signed amdfw ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59867/comment/57ae564e_6ea74523 PS2, Line 13: which means : faster boot time
I’d mention the 60 ms here too. […]
I've removed mainboard part here and working on other patches before we enable feature for specific mainboard(guybrush). I think numbers might change, I'll specify details on the future mainboard CL.
File src/mainboard/google/guybrush/Kconfig:
https://review.coreboot.org/c/coreboot/+/59867/comment/b15f91f5_ffa39bd7 PS2, Line 59: y
We don't want to enable this until we are passing the hash table to the PSP and it is verifying it.
Done
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/59867/comment/25b1470d_ee02b94d PS2, Line 464: amd
AMD
Done
https://review.coreboot.org/c/coreboot/+/59867/comment/ccaa306c_903d1fe9 PS2, Line 465: them and
Comma after *them*?
Done
https://review.coreboot.org/c/coreboot/+/59867/comment/fafcb102_c7910ab5 PS2, Line 465: rely on AMD's verification
… in PSP?
Done
-
Kangheui Won (Code Review)