Attention is currently required from: Arthur Heymans, Dinesh Gehlot, Julius Werner, Lean Sheng Tan, Subrata Banik, Werner Zeh.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76393?usp=email )
Change subject: src: Implement framework for PRERAM VSD store
......................................................................
Patch Set 12:
(3 comments)
Patchset:
PS10:
Sorry, I still disagree with this whole "VSD" thing and the extra APIs you add for it. […]
Although it is temporary, the current implementation has an advantage over static variables that it provides a way to carry data between preram stages.
File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/76393/comment/aa796154_11bc5d9c :
PS12, Line 9: #include <cbmem_vsd.h>
Remove it.
File src/lib/cbmem_vsd.c:
https://review.coreboot.org/c/coreboot/+/76393/comment/b506c03e_144cf1b9 :
PS12, Line 55: if(!cbmem_area)
`space required before the open parenthesis '('`
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76393?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0baebb902807d5403800ac18757512bd2a59d2b9
Gerrit-Change-Number: 76393
Gerrit-PatchSet: 12
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Thu, 03 Aug 2023 06:22:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment