Attention is currently required from: Patrick Rudolph. Curtis Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59952 )
Change subject: soc/intel/common: Not enable crashlog on all resets by default ......................................................................
soc/intel/common: Not enable crashlog on all resets by default
Using the CONFIG_SOC_INTEL_CRASHLOG_ON_RESET to control the crashlog feature - "Trigger_on_all_resets".
BUG=b:202737385 TEST='ls /var/spool/crash/*.bertdump' should be empty after ec apreset.
Signed-off-by: Curtis Chen curtis.chen@intel.com Change-Id: Ide994c8ddebcbc3645a169cfed76daee496070bb --- M src/soc/intel/common/block/crashlog/crashlog.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/59952/1
diff --git a/src/soc/intel/common/block/crashlog/crashlog.c b/src/soc/intel/common/block/crashlog/crashlog.c index c3d0cfd..b9f4417 100644 --- a/src/soc/intel/common/block/crashlog/crashlog.c +++ b/src/soc/intel/common/block/crashlog/crashlog.c @@ -479,8 +479,10 @@ { if (pmc_crashlog_support() && cl_pmc_data_present() && (cl_get_pmc_record_size() > 0)) { +#if CONFIG(SOC_INTEL_CRASHLOG_ON_RESET) cl_pmc_en_gen_on_all_reboot(); printk(BIOS_DEBUG, "Crashlog collection enabled on every reboot.\n"); +#endif cl_get_pmc_sram_data(); } else { printk(BIOS_DEBUG, "Skipping PMC crashLog collection. Data not present.\n");