Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Sridhar Siricilla, Angel Pons, Nick Vaccaro, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61455 )
Change subject: soc/intel/cannonlake: Drop unnecessary guard for HECI1 disable FSP UPD
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/61455/comment/fb7f23f5_80325213
PS3, Line 589: Heci1
Writing Heci1 in the code should be ok, but comment should be HECI1! WDYT?
Don't know about any rule thats support this argument "Writing Heci1 in the code should be ok, but comment should be HECI1!". If you are specific about following the acronym then why not adhere the same all across in my point.
Also, if I just look for your recommendation then also there are ample conflicts. I would prefer to have action that unifies those as well.
src//soc/intel/elkhartlake/romstage/romstage.c:133: /* initialize Heci interface */
src//soc/intel/cannonlake/chip.h:217: /* Heci related */
src//soc/intel/cannonlake/romstage/romstage.c:127: /* initialize Heci interface */
I can update remaining places wherever applicable.
Sure
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61455
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8908c080ca9991e7a71e795ccb8fc76d99514f8
Gerrit-Change-Number: 61455
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Sun, 30 Jan 2022 07:36:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment