[S] Change in coreboot[main]: util/amdfwtool: Check for pkg-config presence - coreboot-gerrit

29 Sep 2023


      Attention is currently required from: Felix Held, Karthik Ramasubramanian, Martin Roth.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78191?usp=email )
Change subject: util/amdfwtool: Check for pkg-config presence
......................................................................
Patch Set 1:
(1 comment)
File util/amdfwtool/Makefile:
https://review.coreboot.org/c/coreboot/+/78191/comment/575882da_f96f9833 :
PS1, Line 26: shell
We just need to check if pkg-config returned a valid code.
https://www.gnu.org/software/make/manual/html_node/Shell-Function.html says that we can check `.SHELLSTATUS`.
This should cover the cases where pkg-config doesn't exist, and if the library isn't found.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78191?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5d604145c919e7f71680d1e095dc68cb21868319
Gerrit-Change-Number: 78191
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 29 Sep 2023 20:15:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment