build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68944 )
Change subject: soc/intel/common/block/oc_wdt: Add OC watchdog common block ......................................................................
Patch Set 1:
(8 comments)
File src/soc/intel/common/block/oc_wdt/oc_wdt.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161578): https://review.coreboot.org/c/coreboot/+/68944/comment/d65b9638_a9041523 PS1, Line 43: return; trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161578): https://review.coreboot.org/c/coreboot/+/68944/comment/198fb389_a36d913a PS1, Line 65: readback = inl(PCH_OC_WDT_CTL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161578): https://review.coreboot.org/c/coreboot/+/68944/comment/b9722a67_5f2ba229 PS1, Line 65: readback = inl(PCH_OC_WDT_CTL); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161578): https://review.coreboot.org/c/coreboot/+/68944/comment/3c081c16_e8d10843 PS1, Line 65: readback = inl(PCH_OC_WDT_CTL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161578): https://review.coreboot.org/c/coreboot/+/68944/comment/d462ea5b_eafacd3d PS1, Line 80: printk (BIOS_ERR, "Watchdog: Failure detected\n"); space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161578): https://review.coreboot.org/c/coreboot/+/68944/comment/16800261_269fe093 PS1, Line 188: printk (BIOS_ERR, "Watchdog: timer expiration detected.\n"); space prohibited between function name and open parenthesis '('
File src/soc/intel/common/block/smm/smm.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161578): https://review.coreboot.org/c/coreboot/+/68944/comment/281110a7_8b049624 PS1, Line 31: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161578): https://review.coreboot.org/c/coreboot/+/68944/comment/afca85f6_f0c062c4 PS1, Line 34: trailing whitespace