Attention is currently required from: Derek Huang, Felix Singer, Henry Sun, Tarun Tuli.
Yunlong Jia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76013?usp=email )
Change subject: mb/google/nissa/var/gothrax: Initialise overridetree ......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brya/variants/gothrax/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/76013/comment/bdbe0747_da8e4ab5 : PS1, Line 34: register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # USB2_A1 : register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" # WFC : register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth port for PCIe WLAN : register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth port for CNVi WLAN : : register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/3 Type A port A1
Don't you need these to enable the USB ports?
I just don't know where is the best place to put it. Please refer to comment#40.
File src/mainboard/google/brya/variants/gothrax/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/76013/comment/1ce57cd0_589e710b : PS3, Line 176: device i2c 0x10 on end
do you have stop_gpio?
Do you mean that we need to "stop_gpio" on the Touchscreen at a certain time?