Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31352 )
Change subject: soc/intel/apl: Implement power-failure-state API ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/31352/8/src/soc/intel/apollolake/pm... File src/soc/intel/apollolake/pmc.c:
https://review.coreboot.org/c/coreboot/+/31352/8/src/soc/intel/apollolake/pm... PS8, Line 110: pmc_set_power_failure_state(PCI_DEV_INVALID);
Please add a comment here as to why you're using PCI_DEV_INVALID
Got rid of the parameter entirely.
https://review.coreboot.org/c/coreboot/+/31352/8/src/soc/intel/apollolake/pm... PS8, Line 130: PCI_DEV_INVALID
Please add a comment here as to why you're using PCI_DEV_INVALID
Got rid of the parameter entirely.
https://review.coreboot.org/c/coreboot/+/31352/2/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/31352/2/src/soc/intel/common/block/... PS2, Line 17: ifeq ($(CONFIG_SPI_FLASH_SMM),y)
To access the NVRAM setting from SMM, you need access to CBFS […]
Done
-
Nico Huber (Code Review)