Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33848
Change subject: lib/gnat: Enable -Werror ......................................................................
lib/gnat: Enable -Werror
We want to catch warnings as early as possible.
Change-Id: Ifdb2ff8f7973d557a437ac127e073306f76ca6f6 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/lib/gnat/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/33848/1
diff --git a/src/lib/gnat/Makefile.inc b/src/lib/gnat/Makefile.inc index c8886ec..ebd0486 100644 --- a/src/lib/gnat/Makefile.inc +++ b/src/lib/gnat/Makefile.inc @@ -25,6 +25,7 @@ -gnatpg \ -I$$(src)/lib/gnat/ \ $$(GCC_ADAFLAGS_$(1)) \ + -Werror \
libgnat-$(1)-y += a-unccon.ads libgnat-$(1)-y += ada.ads
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33848 )
Change subject: lib/gnat: Enable -Werror ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33848 )
Change subject: lib/gnat: Enable -Werror ......................................................................
Patch Set 1: Code-Review+2
Tested building P8Z77-M PRO, let's see if jenkins likes it...
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33848 )
Change subject: lib/gnat: Enable -Werror ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33848 )
Change subject: lib/gnat: Enable -Werror ......................................................................
lib/gnat: Enable -Werror
We want to catch warnings as early as possible.
Change-Id: Ifdb2ff8f7973d557a437ac127e073306f76ca6f6 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/33848 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/lib/gnat/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/lib/gnat/Makefile.inc b/src/lib/gnat/Makefile.inc index c8886ec..ebd0486 100644 --- a/src/lib/gnat/Makefile.inc +++ b/src/lib/gnat/Makefile.inc @@ -25,6 +25,7 @@ -gnatpg \ -I$$(src)/lib/gnat/ \ $$(GCC_ADAFLAGS_$(1)) \ + -Werror \
libgnat-$(1)-y += a-unccon.ads libgnat-$(1)-y += ada.ads
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)