Attention is currently required from: Elyes Haouas, Felix Singer, Jakub Czapiga, Julius Werner, Martin L Roth, Maximilian Brune.
Nico Huber has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83459?usp=email )
Change subject: stddef.h: Introduce nullptr constant
......................................................................
Patch Set 26:
(1 comment)
File src/include/stddef.h:
https://review.coreboot.org/c/coreboot/+/83459/comment/d4972a81_706e3a95?usp... :
PS26, Line 25: #define nullptr ((void *)0)
I don't remember exactly what was said but I agree with Felix here: I think the important part is th […]
To be clear, my concern is only about the `#define nullptr` on the old path, not the C23 path.
As Julius suggests this may help with imported code, but that means we'd have to
weigh if it's more likely to be code that expects `nullptr` to be provided by
`stddef.h` (why would it be? it's not in any standard AFAIK) or code that may
even have a completely different use for this identifier. Seems rather undecidable
to me, so I'd suggest to do less and deal with imported code when it comes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83459?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234
Gerrit-Change-Number: 83459
Gerrit-PatchSet: 26
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 01 Oct 2024 09:37:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr