Attention is currently required from: Angel Pons, Arthur Heymans, Jérémy Compostella, Nico Huber, Tarun Tuli.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67490?usp=email )
Change subject: gma: Update DP training with new fields
......................................................................
Patch Set 18:
(1 comment)
File common/hw-gfx-dp_training.ads:
https://review.coreboot.org/c/libgfxinit/+/67490/comment/d5624e93_2b03110d :
PS8, Line 23: type T (<>) is limited private;
Hi Nico. I was working yesterday on a similar cleanup but like your version better. […]
Sounds like we can resolve this in favor of a separate patch.
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/67490?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I3f7f8a93408a74cfa29d1493a48c88ce73dc690c
Gerrit-Change-Number: 67490
Gerrit-PatchSet: 18
Gerrit-Owner: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 07 Jun 2023 15:58:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-MessageType: comment