Attention is currently required from: Ashish Kumar Mishra, Cliff Huang, Krishna P Bhat D, Saurabh Mishra.
Ronak Kanabar has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83732?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: vc/intel/fsp/fsp2_0/ptl: Add placeholder FSP headers to compile ......................................................................
Patch Set 15:
(3 comments)
File src/vendorcode/intel/fsp/fsp2_0/pantherlake/FirmwareVersionInfo.h:
https://review.coreboot.org/c/coreboot/+/83732/comment/a2a5d5d8_306c6004?usp... : PS15, Line 5: : * This software is released under the MIT License. : * https://opensource.org/licenses/MIT : * : * Permission is hereby granted, free of charge, to any person obtaining a copy : * of this software and associated documentation files (the "Software"), to deal : * in the Software without restriction, including without limitation the rights : * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell : * copies of the Software, and to permit persons to whom the Software is : * furnished to do so, subject to the following conditions: : * : * The above copyright notice and this permission notice shall be included in all : * copies or substantial portions of the Software. : * : * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR : * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, : * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE : * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER : * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, : * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE : * SOFTWARE. : */ need change
ref : https://github.com/coreboot/coreboot/blob/main/src/vendorcode/intel/fsp/fsp2...
File src/vendorcode/intel/fsp/fsp2_0/pantherlake/FspProducerDataHeader.h:
https://review.coreboot.org/c/coreboot/+/83732/comment/1a6d893d_68e1e6fe?usp... : PS15, Line 8: Permission is hereby granted, free of charge, to any person obtaining a copy : * of this software and associated documentation files (the "Software"), to deal : * in the Software without restriction, including without limitation the rights : * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell : * copies of the Software, and to permit persons to whom the Software is : * furnished to do so, subject to the following conditions: : * : * The above copyright notice and this permission notice shall be included in all : * copies or substantial portions of the Software. : * : * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR : * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, : * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE : * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER : * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, : * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE : * SOFTWARE. : */ need change
https://github.com/coreboot/coreboot/blob/main/src/vendorcode/intel/fsp/fsp2...
check this for the ref
File src/vendorcode/intel/fsp/fsp2_0/pantherlake/MemInfoHob.h:
https://review.coreboot.org/c/coreboot/+/83732/comment/a79a86e8_942b4e78?usp... : PS15, Line 3: Memory S3 Save data, Memory Info data and Memory Platform : * data hobs. : * : * Copyright (c) 2024, Intel Corporation. All rights reserved.<BR> : * : * This software is released under the MIT License. : * https://opensource.org/licenses/MIT : * : * Permission is hereby granted, free of charge, to any person obtaining a copy : * of this software and associated documentation files (the "Software"), to deal : * in the Software without restriction, including without limitation the rights : * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell : * copies of the Software, and to permit persons to whom the Software is : * furnished to do so, subject to the following conditions: : * : * The above copyright notice and this permission notice shall be included in all : * copies or substantial portions of the Software. : * : * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR : * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, : * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE : * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER : * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, : * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE : * SOFTWARE. need change
ref : https://github.com/coreboot/coreboot/blob/main/src/vendorcode/intel/fsp/fsp2...