[XS] Change in coreboot[main]: mb/google/dedede/var/awasuki: Tune I2C touchpad for freq and TH - coreboot-gerrit

31 Oct 2024


      Attention is currently required from: Hualin Wei.
Paul Menzel has posted comments on this change by Hualin Wei. ( https://review.coreboot.org/c/coreboot/+/84898?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/dedede/var/awasuki: Tune I2C touchpad for freq and TH
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/dedede/variants/awasuki/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84898/comment/c03b8dd0_8d7deb6d?usp... :
PS10, Line 32: .speed = I2C_SPEED_FAST,
             : 			.speed_config[0] = {
             : 				.speed = I2C_SPEED_FAST,
By the way, does `.speed` need to be set twice?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84898?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5ccaa3a669e18319311de14833966410c7adf40d
Gerrit-Change-Number: 84898
Gerrit-PatchSet: 10
Gerrit-Owner: Hualin Wei weihualin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Weimin Wu wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hualin Wei weihualin@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Thu, 31 Oct 2024 10:44:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No