Attention is currently required from: Ashish Kumar Mishra, Nico Huber.
Balaji Manigandan has posted comments on this change by Balaji Manigandan. ( https://review.coreboot.org/c/coreboot/+/83887?usp=email )
Change subject: Fix no-op for empty arg in Makefile conditional
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Hi, thanks for the patch. The `:` should always work, however also always […]
Thanks for your feedback, Nico.
I hit this issue with
Ubuntu: Release: 24.04
GNU Make 4.3
Built for x86_64-pc-linux-gnu
GNU bash, version 5.2.21(1)-release (x86_64-pc-linux-gnu)
Although I hit this issue due to different change, it can be replicated like:
$(if ,-$(CBFSTOOL) $@.tmp remove -n $(call extract_nth,2,$(file)) 2>/dev/null)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83887?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Gerrit-Change-Number: 83887
Gerrit-PatchSet: 4
Gerrit-Owner: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 19 Aug 2024 10:02:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de