HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42394 )
Change subject: src: Remove unused 'include <cpu/intel/common/common.h> ......................................................................
src: Remove unused 'include <cpu/intel/common/common.h>
Change-Id: I4d749a32aa50fa2f005e8496983013977742a99b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/model_1067x/model_1067x_init.c M src/cpu/intel/model_106cx/model_106cx_init.c M src/cpu/intel/model_6ex/model_6ex_init.c M src/cpu/intel/model_6fx/model_6fx_init.c 4 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/42394/1
diff --git a/src/cpu/intel/model_1067x/model_1067x_init.c b/src/cpu/intel/model_1067x/model_1067x_init.c index 6cb11fe..7230213 100644 --- a/src/cpu/intel/model_1067x/model_1067x_init.c +++ b/src/cpu/intel/model_1067x/model_1067x_init.c @@ -10,7 +10,7 @@ #include <cpu/x86/cache.h> #include <cpu/x86/name.h> #include <cpu/intel/smm_reloc.h> -#include <cpu/intel/common/common.h> + #include "chip.h"
static void init_timer(void) diff --git a/src/cpu/intel/model_106cx/model_106cx_init.c b/src/cpu/intel/model_106cx/model_106cx_init.c index 927bebb..8c462f1 100644 --- a/src/cpu/intel/model_106cx/model_106cx_init.c +++ b/src/cpu/intel/model_106cx/model_106cx_init.c @@ -8,7 +8,6 @@ #include <cpu/intel/speedstep.h> #include <cpu/x86/cache.h> #include <cpu/x86/name.h> -#include <cpu/intel/common/common.h>
#define HIGHEST_CLEVEL 3 static void configure_c_states(void) diff --git a/src/cpu/intel/model_6ex/model_6ex_init.c b/src/cpu/intel/model_6ex/model_6ex_init.c index 43d4599..16c6866 100644 --- a/src/cpu/intel/model_6ex/model_6ex_init.c +++ b/src/cpu/intel/model_6ex/model_6ex_init.c @@ -8,7 +8,6 @@ #include <cpu/intel/speedstep.h> #include <cpu/x86/cache.h> #include <cpu/x86/name.h> -#include <cpu/intel/common/common.h>
#define HIGHEST_CLEVEL 3 static void configure_c_states(void) diff --git a/src/cpu/intel/model_6fx/model_6fx_init.c b/src/cpu/intel/model_6fx/model_6fx_init.c index b81eca4..e2755f8 100644 --- a/src/cpu/intel/model_6fx/model_6fx_init.c +++ b/src/cpu/intel/model_6fx/model_6fx_init.c @@ -8,7 +8,6 @@ #include <cpu/intel/speedstep.h> #include <cpu/x86/cache.h> #include <cpu/x86/name.h> -#include <cpu/intel/common/common.h>
#define HIGHEST_CLEVEL 3 static void configure_c_states(void)
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42394 )
Change subject: src: Remove unused 'include <cpu/intel/common/common.h> ......................................................................
Patch Set 1: Code-Review-1
Could you please just leave comments on any <cpu/x/x> include you think is unnecessary, on the x86-smi-mp topic. I have to move declarations between intel/ x86/ and amd/, there is very high likelyhood of out-of-order merging since gerrit cannot display these dependencies very well.
Hello build bot (Jenkins), Kyösti Mälkki, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42394
to look at the new patch set (#2).
Change subject: src: Remove unused 'include <cpu/intel/common/common.h> ......................................................................
src: Remove unused 'include <cpu/intel/common/common.h>
Found using: diff <(git grep -l '#include <cpu/intel/common/common.h>' -- src/) <(git grep -l 'set_vmx_and_lock|set_feature_ctrl_vmx|set_feature_ctrl_lock|cppc_config|cpu_init_cppc_config|intel_ht_sibling' -- src/) |grep '<'
Change-Id: I4d749a32aa50fa2f005e8496983013977742a99b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/model_1067x/model_1067x_init.c M src/cpu/intel/model_106cx/model_106cx_init.c M src/cpu/intel/model_6ex/model_6ex_init.c M src/cpu/intel/model_6fx/model_6fx_init.c 4 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/42394/2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42394 )
Change subject: src: Remove unused 'include <cpu/intel/common/common.h> ......................................................................
Abandoned
see 41969
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/42394 )
Change subject: src: Remove unused 'include <cpu/intel/common/common.h> ......................................................................
Restored
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42394 )
Change subject: src: Remove unused 'include <cpu/intel/common/common.h> ......................................................................
Patch Set 3:
Patch Set 1: Code-Review-1
Could you please just leave comments on any <cpu/x/x> include you think is unnecessary, on the x86-smi-mp topic. I have to move declarations between intel/ x86/ and amd/, there is very high likelyhood of out-of-order merging since gerrit cannot display these dependencies very well.
I've checked, and if I'm not wrong, there is no conflict with any of touched files in "x86-smi-mp" topic.
Kyösti Mälkki has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/42394 )
Change subject: src: Remove unused 'include <cpu/intel/common/common.h> ......................................................................
Removed Code-Review-1 by Kyösti Mälkki kyosti.malkki@gmail.com
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42394 )
Change subject: src: Remove unused 'include <cpu/intel/common/common.h> ......................................................................
Patch Set 4: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42394 )
Change subject: src: Remove unused 'include <cpu/intel/common/common.h> ......................................................................
Patch Set 5: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42394 )
Change subject: src: Remove unused 'include <cpu/intel/common/common.h> ......................................................................
src: Remove unused 'include <cpu/intel/common/common.h>
Found using: diff <(git grep -l '#include <cpu/intel/common/common.h>' -- src/) <(git grep -l 'set_vmx_and_lock|set_feature_ctrl_vmx|set_feature_ctrl_lock|cppc_config|cpu_init_cppc_config|intel_ht_sibling' -- src/) |grep '<'
Change-Id: I4d749a32aa50fa2f005e8496983013977742a99b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/42394 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/intel/model_1067x/model_1067x_init.c M src/cpu/intel/model_106cx/model_106cx_init.c M src/cpu/intel/model_6ex/model_6ex_init.c M src/cpu/intel/model_6fx/model_6fx_init.c 4 files changed, 1 insertion(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/cpu/intel/model_1067x/model_1067x_init.c b/src/cpu/intel/model_1067x/model_1067x_init.c index e040e0d..cd774d3 100644 --- a/src/cpu/intel/model_1067x/model_1067x_init.c +++ b/src/cpu/intel/model_1067x/model_1067x_init.c @@ -9,7 +9,7 @@ #include <cpu/x86/cache.h> #include <cpu/x86/name.h> #include <cpu/intel/smm_reloc.h> -#include <cpu/intel/common/common.h> + #include "chip.h"
static void init_timer(void) diff --git a/src/cpu/intel/model_106cx/model_106cx_init.c b/src/cpu/intel/model_106cx/model_106cx_init.c index 927bebb..8c462f1 100644 --- a/src/cpu/intel/model_106cx/model_106cx_init.c +++ b/src/cpu/intel/model_106cx/model_106cx_init.c @@ -8,7 +8,6 @@ #include <cpu/intel/speedstep.h> #include <cpu/x86/cache.h> #include <cpu/x86/name.h> -#include <cpu/intel/common/common.h>
#define HIGHEST_CLEVEL 3 static void configure_c_states(void) diff --git a/src/cpu/intel/model_6ex/model_6ex_init.c b/src/cpu/intel/model_6ex/model_6ex_init.c index 43d4599..16c6866 100644 --- a/src/cpu/intel/model_6ex/model_6ex_init.c +++ b/src/cpu/intel/model_6ex/model_6ex_init.c @@ -8,7 +8,6 @@ #include <cpu/intel/speedstep.h> #include <cpu/x86/cache.h> #include <cpu/x86/name.h> -#include <cpu/intel/common/common.h>
#define HIGHEST_CLEVEL 3 static void configure_c_states(void) diff --git a/src/cpu/intel/model_6fx/model_6fx_init.c b/src/cpu/intel/model_6fx/model_6fx_init.c index b81eca4..e2755f8 100644 --- a/src/cpu/intel/model_6fx/model_6fx_init.c +++ b/src/cpu/intel/model_6fx/model_6fx_init.c @@ -8,7 +8,6 @@ #include <cpu/intel/speedstep.h> #include <cpu/x86/cache.h> #include <cpu/x86/name.h> -#include <cpu/intel/common/common.h>
#define HIGHEST_CLEVEL 3 static void configure_c_states(void)
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)