Attention is currently required from: Kapil Porwal, Subrata Banik, Tarun Tuli.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75578?usp=email )
Change subject: mb/google/rex/variants/ovis: Add USB and TCSS configuration ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75578/comment/cf429766_123c3ea9 : PS1, Line 7: USB
USB and TCSS
Done
File src/mainboard/google/rex/variants/ovis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75578/comment/041060a8_e85c7063 : PS1, Line 89: device ref tcss_dma0 on : chip drivers/intel/usb4/retimer : register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B22)" : use tcss_usb3_port1 as dfp[0].typec_port : device generic 0 on end : end : end : device ref tcss_dma1 on : chip drivers/intel/usb4/retimer : register "dfp[0].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B22)" : use tcss_usb3_port2 as dfp[0].typec_port : device generic 0 on end : end : end
`tcss_usb3_port3` is missing from here. […]
Shouldn't the port2 have `generic 1` to match dfp index?