Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42965 )
Change subject: mb/google/dedede/var/drawcia: config DDC SDA/SCL for HDMI ......................................................................
mb/google/dedede/var/drawcia: config DDC SDA/SCL for HDMI
BUG=none TEST=build drawcia, and check hdmi output
Change-Id: Id971e2210e5612a8546eaf979d054eade87308c3 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/dedede/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/42965/1
diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index 71c0c14..c8a7eae 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -224,9 +224,9 @@ /* E16 : GPP_E16/DDI1_DDC_SDA */ PAD_NC(GPP_E16, NONE), /* E17 : HDMI_DDC_SCL */ - PAD_NC(GPP_E17, NONE), + PAD_CFG_NF(GPP_E17, NONE, DEEP, NF1), /* E18 : HDMI_DDC_SDA */ - PAD_NC(GPP_E18, NONE), + PAD_CFG_NF(GPP_E18, NONE, DEEP, NF1), /* E19 : GPP_E19/IMGCLKOUT_5/PCIE_LNK_DOWN */ PAD_NC(GPP_E19, NONE), /* E20 : CNV_BRI_DT_R */
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42965 )
Change subject: mb/google/dedede/var/drawcia: config DDC SDA/SCL for HDMI ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42965/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42965/1//COMMIT_MSG@8 PS1, Line 8: Please describe the problem.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42965 )
Change subject: mb/google/dedede/var/drawcia: config DDC SDA/SCL for HDMI ......................................................................
Patch Set 1:
This CL can be abandoned, since there is a duplicate CL: https://review.coreboot.org/c/coreboot/+/43294
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42965 )
Change subject: mb/google/dedede/var/drawcia: config DDC SDA/SCL for HDMI ......................................................................
Patch Set 1:
Patch Set 1:
This CL can be abandoned, since there is a duplicate CL: https://review.coreboot.org/c/coreboot/+/43294
Thanks, I will abandon it.
Chen Wisley has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42965 )
Change subject: mb/google/dedede/var/drawcia: config DDC SDA/SCL for HDMI ......................................................................
Abandoned