Attention is currently required from: Furquan Shaikh, Karthik Ramasubramanian, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56818 )
Change subject: soc/amd/common/block/spi: Don't update spi speed if EFS is changed ......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/spi/fch_spi.c:
https://review.coreboot.org/c/coreboot/+/56818/comment/afa72f20_bf7ec833 PS2, Line 84: if (CONFIG(EM100)) : fch_spi_config_em100_modes(); : else : fch_spi_config_mb_modes();
This should be completely dropped and instead coreboot should rely on using EFS fields to determine […]
Do you realize that EFS only configures some of the speeds, not all of them? Do you understand that this would allow us to use EM100 with our pre-built images instead of requiring a rebuild? Do you realize that not all boards being used right now can run at the higher speeds that we're transitioning to?
With all of that in mind, and understanding that we can't JUST use EFS for configuration, do you still think that this should be dropped?