Change in coreboot[master]: mb/google/herobrine: Transition BOARD_HEROBRINE to BOARD_HEROBRINE_PR...

[Julius Werner (Code Review)]

Attention is currently required from: Shelley Chen.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60284 )

Change subject: mb/google/herobrine: Transition BOARD_HEROBRINE to BOARD_HEROBRINE_PROTO0
......................................................................

Patch Set 1:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/60284/comment/af5e9acb_045d4265 
PS1, Line 7: _PROTO0
Remember to only refer to build stages by revision number (i.e. HEROBRINE_REV0) is public contexts, not names that can be used to infer project schedule (proto, EVT, DVT, etc.). (In the case of rev0 it's kinda obvious that it would be a Proto board so I don't think we need to treat this as a "leak" right now, but still change the patch to avoid setting a bad example.)

File src/mainboard/google/herobrine/mainboard.c:

https://review.coreboot.org/c/coreboot/+/60284/comment/2c642695_32438ae7 
PS1, Line 78: 	}
Shouldn't we add a new BOARD_GOOGLE_HEROBRINE case now? (In general I think code should always be written such that the default case is what we assume to most likely be correct for boards we'll add in the future. In this case, I presume the existing Herobrine rev0 case is also correct for rev1 and most likely future boards in the family, so I'd just rewrite this as

if (...piglin || hoglin...) {
   ...piglin/hoglin case...
 } else {
   ...previous herobrine rev0 case...
 }