Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45928 )
Change subject: mb/clevo/l140cu: Fix raminit ......................................................................
mb/clevo/l140cu: Fix raminit
Add romstage.c to Makefile to fix raminit.
Change-Id: I7afbf1574803128f7d62592eed2398c945334757 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/45928/1
diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc b/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc index 3d742d6..bd3e899 100644 --- a/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc +++ b/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc @@ -1,4 +1,5 @@ bootblock-y += bootblock.c +romstage-y += romstage.c ramstage-y += ramstage.c ramstage-y += hda_verb.c SPD_SOURCES = samsung-K4AAG165WA-BCTD
Hello Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45928
to look at the new patch set (#2).
Change subject: mb/clevo/l140cu: Add variant specific romstage.c to build ......................................................................
mb/clevo/l140cu: Add variant specific romstage.c to build
While restructuring the mainboard directory, it was forgotten to add the variant specific romstage.c to the build. Therefore, add romstage.c to the Makefile fixing the raminit.
Change-Id: I7afbf1574803128f7d62592eed2398c945334757 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/45928/2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45928 )
Change subject: mb/clevo/l140cu: Add variant specific romstage.c to build ......................................................................
Patch Set 2: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45928 )
Change subject: mb/clevo/l140cu: Add variant specific romstage.c to build ......................................................................
mb/clevo/l140cu: Add variant specific romstage.c to build
While restructuring the mainboard directory, it was forgotten to add the variant specific romstage.c to the build. Therefore, add romstage.c to the Makefile fixing the raminit.
Change-Id: I7afbf1574803128f7d62592eed2398c945334757 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/45928 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc b/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc index 3d742d6..bd3e899 100644 --- a/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc +++ b/src/mainboard/clevo/cml-u/variants/l140cu/Makefile.inc @@ -1,4 +1,5 @@ bootblock-y += bootblock.c +romstage-y += romstage.c ramstage-y += ramstage.c ramstage-y += hda_verb.c SPD_SOURCES = samsung-K4AAG165WA-BCTD
-
Felix Singer (Code Review) -
Michael Niewöhner (Code Review)