Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46464 )
Change subject: cpu/intel/common: correct MSR for the Nominal Performance in CPPC
......................................................................
Patch Set 4: Code-Review+1
Seems alright to me, though I can't speak to the msr.h part.
It's been awhile so I'm not sure if the use of 0x771 was accidental (i.e., overlooked that this field was an exception to how the ACPI definition seemed to go along with the MSR layout), or intentional (e.g., looked at an older reference or tried to avoid using an MSR that might not be present). In any case, this change seems consistent with other firmwares and Skylake is reading from MSR_PLATFORM_INFO in other places so I shouldn't be too concerned about whether it's present or not.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46464
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2c27fd3e14af18aa4101c0acd7a5ede15d1f3a9
Gerrit-Change-Number: 46464
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 15 Oct 2020 18:36:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment