Attention is currently required from: Hung-Te Lin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60318 )
Change subject: soc/mediatek/mt8186: Add DRAM full calibration support ......................................................................
Patch Set 1:
(19 comments)
File src/soc/mediatek/mt8186/include/soc/dramc_soc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/ce8cddc3_1ffcb171 PS1, Line 7: CHANNEL_A = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/9fdede0e_b7b02584 PS1, Line 8: CHANNEL_B, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/976c345d_59f26722 PS1, Line 9: CHANNEL_MAX, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/62203819_73264b1b PS1, Line 13: RANK_0 = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/1125c45c_cbf559a7 PS1, Line 14: RANK_1, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/b52d1ba3_82d7fa51 PS1, Line 15: RANK_MAX, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/3c6afd05_408f281f PS1, Line 20: DRAM_DFS_SHUFFLE_1 = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/5cf34ced_acc17372 PS1, Line 21: DRAM_DFS_SHUFFLE_2, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/1a8aa9e6_8856f59f PS1, Line 22: DRAM_DFS_SHUFFLE_3, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/36499f5f_bbfeab3e PS1, Line 23: DRAM_DFS_SHUFFLE_4, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/4fa6d15d_42f5e8be PS1, Line 24: DRAM_DFS_SHUFFLE_5, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/320d569d_356a14c8 PS1, Line 25: DRAM_DFS_SHUFFLE_6, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/f4c9cab5_a4de0d3f PS1, Line 26: DRAM_DFS_SHUFFLE_7, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/67d6b5f1_f7518410 PS1, Line 27: DRAM_DFS_SHUFFLE_8, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/65ea16ab_29c9268f PS1, Line 28: DRAM_DFS_SHUFFLE_9, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/2ed38f88_a76fd696 PS1, Line 29: DRAM_DFS_SHUFFLE_10, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/4c0a7d83_3ff81528 PS1, Line 30: DRAM_DFS_SHUFFLE_MAX, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/7d0ff110_20ed909e PS1, Line 41: CBT_NORMAL_MODE = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136072): https://review.coreboot.org/c/coreboot/+/60318/comment/e76e7257_f208bf7c PS1, Line 42: CBT_BYTE_MODE1, please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)